-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re)Enable EIP IPv6 E2Es and fix issue with test #4580
Conversation
Saw E2E flake #3986 |
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
…ility Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Rebased only |
test/e2e/util.go
Outdated
if op == "delete" && notFound { | ||
// rule is not there | ||
return | ||
} else if op == "append" && err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we getting confused about "insert" vs "append"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, it looks like it. I didnt want to make changes to code I didnt write here. It looks like no func error here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a low hanging fruit though, who knows, might be related to one of our many flakes.
Have you tried replacing append
with insert
here to check what happens to the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine - changed it
IPv6 link addresses behave differently than IPv4 addresses when a link is enslaved to a VRF device. For IPv4, addresses assigned to the link are preserved but for IPv6, non link local addresses are removed. Therefore when a link is enslaved, this commit manually readds the global IPv6 address. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
c36574f
to
cf8ca64
Compare
Previous op was invalid. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Issue was healthcheck test didnt consider IPv6 when adding iptable rule to drop packets therefore test would fail because failover didnt occur.
Fixes: #4130