(Re)Enable EIP IPv6 E2Es and fix issue with test #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saw E2E flake #3986 |
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
…ility Signed-off-by: Martin Kennelly <mkennell@redhat.com>
|
Rebased only |
jcaamano
reviewed
Aug 27, 2024
test/e2e/util.go
Outdated
| if op == "delete" && notFound { | ||
| // rule is not there | ||
| return | ||
| } else if op == "append" && err == nil { |
There was a problem hiding this comment.
Are we getting confused about "insert" vs "append"?
There was a problem hiding this comment.
ya, it looks like it. I didnt want to make changes to code I didnt write here. It looks like no func error here.
There was a problem hiding this comment.
looks like a low hanging fruit though, who knows, might be related to one of our many flakes.
Have you tried replacing append with insert here to check what happens to the tests?
There was a problem hiding this comment.
works fine - changed it
IPv6 link addresses behave differently than IPv4 addresses when a link is enslaved to a VRF device. For IPv4, addresses assigned to the link are preserved but for IPv6, non link local addresses are removed. Therefore when a link is enslaved, this commit manually readds the global IPv6 address. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
martinkennelly
force-pushed
the
v6-eip
branch
from
c36574f
to
cf8ca64
Compare
Previous op was invalid. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
jcaamano
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was healthcheck test didnt consider IPv6 when adding iptable rule to drop packets therefore test would fail because failover didnt occur.
Fixes: #4130