Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unixctl to ovn-controller #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SamYaple
Copy link

@SamYaple SamYaple commented Jan 4, 2024

This just add --unixctl option to the ovn-controller daemon to bring it inline with available options in other daemons.

This just add `--unixctl` option to the ovn-controller daemon to bring
it inline with available options in other daemons.

Signed-off-by: Sam Yaple <sam@yaple.net>
Copy link
Collaborator

@dceara dceara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SamYaple! It looks OK but we're missing an update to the documentation part. For example for ovn-northd we have this:

   Other Options
       --unixctl=socket
              Sets the name of the control socket on which program listens for
              runtime  management  commands  (see RUNTIME MANAGEMENT COMMANDS,
              below). If socket does not begin with /, it  is  interpreted  as
              relative  to  .  If  --unixctl  is  not used at all, the default
              socket is /program.pid.ctl, where pid is program’s process ID.

              On Windows a local named pipe is used to listen for runtime man‐
              agement  commands.  A  file  is  created in the absolute path as
              pointed by socket or if --unixctl is not used at all, a file  is
              created  as  program in the configured OVS_RUNDIR directory. The
              file exists just to mimic the behavior of a Unix domain socket.

              Specifying none for socket disables the control socket feature.

That's generated here:

<h2>Other Options</h2>
<xi:include href="lib/unixctl.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
<h3></h3>

Also, it's not mandatory, but to get the most attention from OVN maintainers it's probably faster if you post your change as a patch to the mailing list. The contribution guidelines are available here:
https://docs.ovn.org/en/latest/internals/contributing/submitting-patches.html

Thanks,
Dumitru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants