northd: Fix issues for Forwarding_Group

[ZhangQiang3]

The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely.
eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22),fwg3(p31,p32),only fwg1 in logical_flows

[numansiddique]

Thanks for the patch. I'll take a look.

[numansiddique]

@ZhangQiang3 Can you please provide your Signed-off-by tag ?

You just need to update the commit message with the below line and update this PR

Signed-off-by: Author Name <author.name@email.address...>

Please see https://docs.ovn.org/en/latest/internals/contributing/submitting-patches.html

Thanks

[numansiddique]

Thank you for the PR. I manually pushed this PR. I added your name to the AUTHORS list and applied with the below changes :

diff --git a/northd/northd.c b/northd/northd.c
index be1a1e288b..fe7753f824 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -7922,7 +7922,7 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows,
     struct ds actions = DS_EMPTY_INITIALIZER;
     struct ds group_ports = DS_EMPTY_INITIALIZER;
 
-    for (int i = 0; i < od->nbs->n_forwarding_groups; ++i) {
+    for (size_t i = 0; i < od->nbs->n_forwarding_groups; ++i) {
         const struct nbrec_forwarding_group *fwd_group = NULL;
         fwd_group = od->nbs->forwarding_groups[i];
         if (!fwd_group->n_child_port) {
@@ -7964,7 +7964,7 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows,
         ds_put_cstr(&group_ports, "childports=");
         for (size_t j = 0; j < (fwd_group->n_child_port - 1); ++j) {
             ds_put_format(&group_ports, "\"%s\",",
-                         fwd_group->child_port[j]);
+                          fwd_group->child_port[j]);
         }
         ds_put_format(&group_ports, "\"%s\"",
                       fwd_group->child_port[fwd_group->n_child_port - 1]);