-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
northd: Fix issues for Forwarding_Group #250
Conversation
ZhangQiang3
commented
Jul 8, 2024
bd17132
to
805422a
Compare
Thanks for the patch. I'll take a look. |
@ZhangQiang3 Can you please provide your Signed-off-by tag ? You just need to update the commit message with the below line and update this PR Signed-off-by: Author Name <author.name@email.address...> Please see https://docs.ovn.org/en/latest/internals/contributing/submitting-patches.html Thanks |
The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22), fwg3(p31,p32),only fwg1 in logical_flows. Signed-off-by: zhangqiang45 <zhangqiang45@lenovo.com>
The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22), fwg3(p31,p32),only fwg1 in logical_flows. Submitted-at: #250 Signed-off-by: zhangqiang45 <zhangqiang45@lenovo.com> Signed-off-by: Numan Siddique <numans@ovn.org>
Thank you for the PR. I manually pushed this PR. I added your name to the AUTHORS list and applied with the below changes :
|
The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22), fwg3(p31,p32),only fwg1 in logical_flows. Submitted-at: ovn-org#250 Signed-off-by: zhangqiang45 <zhangqiang45@lenovo.com> Signed-off-by: Numan Siddique <numans@ovn.org> (cherry picked from commit b64c564)
The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22), fwg3(p31,p32),only fwg1 in logical_flows. Submitted-at: ovn-org#250 Signed-off-by: zhangqiang45 <zhangqiang45@lenovo.com> Signed-off-by: Numan Siddique <numans@ovn.org> (cherry picked from commit b64c564)
The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22), fwg3(p31,p32),only fwg1 in logical_flows. Submitted-at: ovn-org#250 Signed-off-by: zhangqiang45 <zhangqiang45@lenovo.com> Signed-off-by: Numan Siddique <numans@ovn.org> (cherry picked from commit b64c564)