Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on MOD OPTIONS tab hides menu elements #585

Closed
MarcosGarro opened this issue May 9, 2024 · 1 comment · Fixed by #597
Closed

Clicking on MOD OPTIONS tab hides menu elements #585

MarcosGarro opened this issue May 9, 2024 · 1 comment · Fixed by #597
Assignees
Labels
bug Something isn't working fixed-in-dev This issue has been fixed in an in-development version. menus Something to do with the in-game menus that OWML can generate.

Comments

@MarcosGarro
Copy link

When you open the options of a mod, it opens a new tab that if you click on it, the mod menu items disappear, as you can see in the video. Clearly touching that tab should not do anything, like the rest of the tabs that you touch when you are already in their respective menu.

Anyway, I don't understand the existence of this new tab (MOD OPTIONS), it looks very weird that a tab appears where it wasn't before. In my opinion, it could be eliminated and it would not be necessary to add another title that serves to indicate that you are in the options of a mod.

A separate suggestion I have is that I think the MODS sub tab should be on the left and selected by default, instead of OWML, since the average user is going to go to that one more often (the OWML one would be strange if a player uses it), involves an annoying extra step for someone who wants to tinker with the options of the mods they are trying out.

Mod.Options.Tab.mp4
@JohnCorby JohnCorby added bug Something isn't working menus Something to do with the in-game menus that OWML can generate. labels Aug 21, 2024
@misternebula
Copy link
Member

Due to how the menus work in the base game, the extra tab appearing was the best compromise I could do. I'll look into why it dissapears when clicking the same tab, and I can definitely swap the buttons around.

@misternebula misternebula self-assigned this Oct 10, 2024
@misternebula misternebula added the fixed-in-dev This issue has been fixed in an in-development version. label Oct 10, 2024
@misternebula misternebula linked a pull request Oct 10, 2024 that will close this issue
misternebula added a commit that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed-in-dev This issue has been fixed in an in-development version. menus Something to do with the in-game menus that OWML can generate.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants