-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #3314
base: v3/master
Are you sure you want to change the base?
Update README.md #3314
Conversation
Update Windows README to use latest conan version and conan center.
Please update the Conan version in the Dockerfile as well so that it's in sync with the Win32 build instructions. AFAIK, the 'Conan Center' change is unrelated to the 32-bit build issue. |
Update Docker to latest conan version 2.10.2
I have updated the docker file to use version 2.10.2 if you like i can remove the conan center change although i think it would be recommended to make sure people are downloading correct remotes for future builds right? |
I'd favor keeping the build steps minimal, to cover just what is required to build the library, and leave the defaults setup by the Conan installer. BTW, the default Conan Center for Conan 2 seems to actually be https://center2.conan.io since version 2.9.2, see conan-io/conan-center-index@74bc767 |
Remove conan center change
Oh i thought i used that one guess i didnt, Anyway i've removed the conan center changes in the readme.md file |
Quality Gate passedIssues Measures |
guys do you have any idea why are the test failed? It seems like not the same place, but random places: https://github.com/owasp-modsecurity/ModSecurity/actions/runs/12270940148/job/34241868930?pr=3314#step:5:6 And only on OSX. Thanks. |
This one appears to show that
Not sure about this one, it seems |
Thanks! I try to figure out what can we do. |
Update Windows README to use latest conan version 2.10.2
what
Update the README file for windows builds
why
Because it asks to install out of date conan version which can result in libiconv errors when compiling for 32-bit
references
#3313