Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mobile layout About page #169

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix mobile layout About page #169

merged 1 commit into from
Jun 16, 2023

Conversation

jamcgrath
Copy link
Contributor

Description

refactored css to fix

Motivation and Context

#168 (comment)

How Has This Been Tested?

tested local in browsers, xcode simulator and multiple devices in browserstack.
Could use more testing.

Screenshots (if appropriate):

Simulator Screenshot - iPhone 14 Pro Max - 2023-06-16 at 00 29 04

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@jamcgrath jamcgrath changed the title fix mobile layout fix mobile layout About page Jun 16, 2023
martinheidegger
martinheidegger approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@martinheidegger martinheidegger merged commit 5eeb37e into owddm:main Jun 16, 2023
3 checks passed
@kinxiel
Copy link
Collaborator

kinxiel commented Jun 17, 2023

Awesome. Works fine on my phone as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinheidegger martinheidegger martinheidegger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamcgrath @kinxiel @martinheidegger