Make queued audits feature opt-in #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2023
MortenDHansen
approved these changes
Dec 15, 2023
|
Seems like a good fix. Im not sure if there is something we should take into account before releasing it? (@Orrison ? ) |
|
This should do the trick I believe. |
Orrison
approved these changes
Dec 15, 2023
|
I didn't know how to solve my problem, but with this at least I don't have to go back to a previous version |
parallels999
approved these changes
Dec 15, 2023
angeljqv
approved these changes
Dec 15, 2023
|
Isn't this technically making it "opt-out" since the default is now to queue where it wasn't previously? |
cosmastech
reviewed
Dec 18, 2023
| return; | ||
| } | ||
|
|
||
| if (!Config::get('audit.queue.enable', true)) { |
There was a problem hiding this comment.
This should be defaulting to false to make it opt-in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.