Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Limit container names to 28 characters #3740

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Dec 18, 2024

Fix for owid/owid-grapher#4308

Truncate branch names after 28 characters instead of 50. (Existing branches over 28 characters are excluded)

@Marigold Marigold marked this pull request as ready for review December 18, 2024 12:29
@Marigold Marigold requested a review from danyx23 December 18, 2024 12:29
@owidbot
Copy link
Contributor

owidbot commented Dec 18, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-container-name-28-chars

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-12-18 12:32:10 UTC
Execution time: 17.00 seconds

@Marigold Marigold merged commit 7fce2ec into master Dec 19, 2024
12 checks passed
@Marigold Marigold deleted the container-name-28-chars branch December 19, 2024 08:31
antea04 pushed a commit that referenced this pull request Feb 5, 2025
* ✨ Limit container names to 28 characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants