enhance: revert MissingDataStrategy.auto behavior

owid · Aug 15, 2024 · 286c2ee · 286c2ee
1 parent 0d16ece
commit 286c2ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 22 deletions.
diff --git a/packages/@ourworldindata/core-table/src/OwidTable.ts b/packages/@ourworldindata/core-table/src/OwidTable.ts
@@ -277,20 +277,6 @@ export class OwidTable extends CoreTable<OwidRow, OwidColumnDef> {
         )
     }
 
-    dropRowsWithAtLeastThisManyErrorValuesForColumns(
-        slugs: ColumnSlug[],
-        minErrorValues: number
-    ): this {
-        return this.rowFilter(
-            (row) =>
-                slugs.filter((slug) => !isNotErrorValue(row[slug])).length <
-                minErrorValues,
-            `Drop rows with at least ${minErrorValues} ErrorValues in every column: ${slugs.join(
-                ", "
-            )}`
-        )
-    }
-
     // Drop _all rows_ for an entity if there is any column that has no valid values for that entity.
     dropEntitiesThatHaveNoDataInSomeColumn(columnSlugs: ColumnSlug[]): this {
         const indexesByEntityName = this.rowIndicesByEntityName

diff --git a/packages/@ourworldindata/grapher/src/stackedCharts/StackedDiscreteBarChart.tsx b/packages/@ourworldindata/grapher/src/stackedCharts/StackedDiscreteBarChart.tsx
@@ -130,15 +130,9 @@ export class StackedDiscreteBarChart
             // If MissingDataStrategy is explicitly set to hide, drop rows (= times) where one of
             // the y columns has no data
             return table.dropRowsWithErrorValuesForAnyColumn(this.yColumnSlugs)
-        } else if (this.missingDataStrategy === MissingDataStrategy.auto) {
-            // If MissingDataStrategy is set to auto, drop rows where there is only a single non-error value
-            if (this.yColumnSlugs.length > 1) {
-                return table.dropRowsWithAtLeastThisManyErrorValuesForColumns(
-                    this.yColumnSlugs,
-                    this.yColumnSlugs.length - 1
-                )
-            }
         }
+
+        // Otherwise, don't apply any special treatment
         return table
     }