perf: only sort at the end

owid · Aug 29, 2024 · 7bb41e4 · 7bb41e4
1 parent 5e05a3d
commit 7bb41e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/@ourworldindata/core-table/src/OwidTable.ts b/packages/@ourworldindata/core-table/src/OwidTable.ts
@@ -186,7 +186,7 @@ export class OwidTable extends CoreTable<OwidRow, OwidColumnDef> {
     }
 
     // Does a stable sort by time. You can refer to this table for fast time filtering.
-    @imemo private get sortedByTime(): this {
+    @imemo get sortedByTime(): this {
         if (this.timeColumn.isMissing) return this
         return this.sortBy([this.timeColumn.slug])
     }

diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -811,7 +811,7 @@ export class Grapher
         if (this.isSlopeChart)
             return table.filterByTargetTimes([startTime, endTime])
 
-        return table.filterByTimeRange(startTime, endTime)
+        return table.filterByTimeRange(startTime, endTime).sortedByTime
     }
 
     @computed get transformedTable(): OwidTable {