Skip to content

Commit

Permalink
Merge pull request #3942 from owid/fix-scatterplot-regression
Browse files Browse the repository at this point in the history
🐛 fix hideLinesOutsideTolerance behaviour always kicking in instead of never
  • Loading branch information
danyx23 authored Sep 9, 2024
2 parents 85e049a + 30243fd commit 9c1a2a2
Showing 1 changed file with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -316,21 +316,6 @@ export class ScatterPlotChart
// TODO chunk this up into multiple computeds for better performance?
@computed get transformedTable(): OwidTable {
let table = this.transformedTableFromGrapher
if (
this.manager.startTime !== undefined &&
this.manager.endTime !== undefined
) {
const entityNames = Array.from(
intersectionOfSets(
[this.manager.startTime, this.manager.endTime].map(
(targetTime) =>
table.filterByTargetTimes([targetTime], 0)
.availableEntityNameSet
)
)
)
table = table.filterByEntityNames(entityNames)
}
// We don't want to apply this transform when relative mode is also enabled, it has a
// sligthly different endpoints logic that drops initial zeroes to avoid DivideByZero error.
if (this.compareEndPointsOnly && !this.manager.isRelativeMode) {
Expand Down

0 comments on commit 9c1a2a2

Please sign in to comment.