🔨 Set dimensions again after loading the input table

(tests and svg tester were green without it, probably not necessary and will be replaced in a later PR)
owid · Feb 3, 2025 · a023ee0 · a023ee0
1 parent d148826
commit a023ee0
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -114,6 +114,7 @@ import {
     GrapherTabOption,
     SeriesName,
     ChartViewInfo,
+    OwidChartDimensionInterfaceWithMandatorySlug,
 } from "@ourworldindata/types"
 import {
     BlankOwidTable,
@@ -1180,18 +1181,19 @@ export class Grapher
         // TODO grapher model: switch this to downloading multiple data and metadata files
 
         const startMark = performance.now()
-        const dimensions = legacyConfig.dimensions?.map((dimension) => ({
-            ...dimension,
-            slug:
-                dimension.slug ??
-                getDimensionColumnSlug(
-                    dimension.variableId,
-                    dimension.targetYear
-                ),
-        }))
+        const dimensions: OwidChartDimensionInterfaceWithMandatorySlug[] =
+            legacyConfig.dimensions?.map((dimension) => ({
+                ...dimension,
+                slug:
+                    dimension.slug ??
+                    getDimensionColumnSlug(
+                        dimension.variableId,
+                        dimension.targetYear
+                    ),
+            })) ?? []
         const tableWithColors = legacyToOwidTableAndDimensions(
             json,
-            dimensions ?? [],
+            dimensions,
             legacyConfig.selectedEntityColors
         )
         this.createPerformanceMeasurement(
@@ -1203,6 +1205,10 @@ export class Grapher
             this.inputTable = inputTableTransformer(tableWithColors)
         else this.inputTable = tableWithColors
 
+        // We need to reset the dimensions because some of them may have changed slugs in the legacy
+        // transformation (can happen when columns use targetTime)
+        this.setDimensionsFromConfigs(dimensions)
+
         this.appendNewEntitySelectionOptions()
 
         if (this.manager?.selection?.hasSelection) {