🐛 (admin) only evaluate chart series names once Grapher is ready

owid · Dec 17, 2024 · b3eda9e · b3eda9e
1 parent b2c21dc
commit b3eda9e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/@ourworldindata/core-table/src/CoreTable.ts b/packages/@ourworldindata/core-table/src/CoreTable.ts
@@ -1142,6 +1142,7 @@ export class CoreTable<
     ): this {
         const newStore: CoreColumnStore = { ...this.columnStore }
         columnSlugs.forEach((slug) => {
+            console.log(slug, newStore[slug])
             newStore[slug] = newStore[slug].map(replaceFn)
         })
         return this.transform(

diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -885,6 +885,8 @@ export class Grapher
     }
 
     @computed get chartSeriesNames(): SeriesName[] {
+        if (!this.isReady) return []
+
         // collect series names from all chart instances when faceted
         if (this.isFaceted) {
             const facetChartInstance = new FacetChart({ manager: this })