fix(gdoc): do not override subclass props if defined

owid · May 9, 2024 · c6d2547 · c6d2547
1 parent f90a5a9
commit c6d2547
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/db/model/Gdoc/GdocDataInsight.ts b/db/model/Gdoc/GdocDataInsight.ts
@@ -7,6 +7,7 @@ import {
     OwidGdocMinimalPostInterface,
     OwidGdocBaseInterface,
     excludeNullish,
+    defaults,
 } from "@ourworldindata/utils"
 import { GdocBase } from "./GdocBase.js"
 import * as db from "../../../db/db.js"
@@ -27,7 +28,7 @@ export class GdocDataInsight
 
     static create(obj: OwidGdocBaseInterface): GdocDataInsight {
         const gdoc = new GdocDataInsight()
-        Object.assign(gdoc, obj)
+        defaults(gdoc, obj) // see GdocAuthor.ts for rationale
         return gdoc
     }
 

diff --git a/db/model/Gdoc/GdocHomepage.ts b/db/model/Gdoc/GdocHomepage.ts
@@ -5,6 +5,7 @@ import {
     OwidGdocHomepageInterface,
     OwidGdocMinimalPostInterface,
     OwidGdocType,
+    defaults,
 } from "@ourworldindata/utils"
 import { GdocBase } from "./GdocBase.js"
 import * as db from "../../db.js"
@@ -28,7 +29,7 @@ export class GdocHomepage
 
     static create(obj: OwidGdocBaseInterface): GdocHomepage {
         const gdoc = new GdocHomepage()
-        Object.assign(gdoc, obj)
+        defaults(gdoc, obj) // see GdocAuthor.ts for rationale
         return gdoc
     }
 

diff --git a/db/model/Gdoc/GdocPost.ts b/db/model/Gdoc/GdocPost.ts
@@ -12,6 +12,7 @@ import {
     OwidGdocMinimalPostInterface,
     OwidGdocBaseInterface,
     excludeNullish,
+    defaults,
 } from "@ourworldindata/utils"
 import { GDOCS_DETAILS_ON_DEMAND_ID } from "../../../settings/serverSettings.js"
 import {
@@ -37,7 +38,7 @@ export class GdocPost extends GdocBase implements OwidGdocPostInterface {
     }
     static create(obj: OwidGdocBaseInterface): GdocPost {
         const gdoc = new GdocPost()
-        Object.assign(gdoc, obj)
+        defaults(gdoc, obj) // see GdocAuthor.ts for rationale
         return gdoc
     }
     linkedDocuments: Record<string, OwidGdocMinimalPostInterface> = {}