Skip to content

Commit

Permalink
enhance(svg): output svg using color none instead of transparent
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelgerber committed Sep 4, 2023
1 parent acf4b29 commit d830a01
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ import {
NumericBin,
} from "../color/ColorScaleBin"

const facetBackgroundColor = "transparent" // we don't use color yet but may use it for background later
const facetBackgroundColor = "none" // we don't use color yet but may use it for background later

const getContentBounds = (
containerBounds: Bounds,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ export class LineChart
onTouchMove={this.onCursorMove}
>
{clipPath.element}
<rect {...this.bounds.toProps()} fill="transparent">
<rect {...this.bounds.toProps()} fill="none">
{/* This <rect> ensures that the parent <g> is big enough such that we get mouse hover events for the
whole charting area, including the axis, the entity labels, and the whitespace next to them.
We need these to be able to show the tooltip for the first/last year even if the mouse is outside the charting area. */}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ export class StackedAreaChart
onTouchMove={this.onCursorMove}
>
{clipPath.element}
<rect {...this.bounds.toProps()} fill="transparent">
<rect {...this.bounds.toProps()} fill="none">
{/* This <rect> ensures that the parent <g> is big enough such that we get mouse hover events for the
whole charting area, including the axis, the entity labels, and the whitespace next to them.
We need these to be able to show the tooltip for the first/last year even if the mouse is outside the charting area. */}
Expand Down

0 comments on commit d830a01

Please sign in to comment.