Skip to content

Commit

Permalink
docs(author): improve defaults explanation
Browse files Browse the repository at this point in the history
  • Loading branch information
mlbrgl committed May 9, 2024
1 parent 6858f24 commit da436bb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions db/model/Gdoc/GdocAuthor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export class GdocAuthor extends GdocBase implements OwidGdocAuthorInterface {
// _enrichedSubclassContent would run from the base GdocBase class
// instead of the GdocAuthor subclass, and the socials block would not
// be shaped as an ArchieML block, thus throwing an error.

// A first approach to avoid this would be to use Object.assign(), while
// omitting functions:
// Object.assign(gdoc, omitBy(obj, isFunction))

// However this approach still lets the parent class override properties
Expand Down

0 comments on commit da436bb

Please sign in to comment.