Skip to content

Commit

Permalink
docs(author): update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mlbrgl committed May 17, 2024
1 parent 1d14c4e commit e22c44c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions db/model/Gdoc/GdocAuthor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ export class GdocAuthor extends GdocBase implements OwidGdocAuthorInterface {
// are ignored. Even after the assign, gdoc._enrichedSubclassContent()
// will then still accurately target the GdocAuthor method, and not the
// GdocBase method.

// see
// https://github.com/owid/owid-grapher/pull/3600#issuecomment-2116990248
// for a more detailed presentation on this topic

Object.assign(gdoc, obj)
return gdoc
}
Expand Down
2 changes: 1 addition & 1 deletion db/model/Gdoc/GdocFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export async function createGdocAndInsertIntoDb(
// enrichments are not present on the Gdoc subclass when loading from the DB
// (GdocsContentSource.Internal), since subclass enrichements are only done
// while fetching the live gdocs (GdocsContentSource.Gdocs) in
// loadFromGdocBase().
// loadGdocFromGdocBase().
await upsertGdoc(knex, gdoc)

return gdoc
Expand Down

0 comments on commit e22c44c

Please sign in to comment.