🔨 incorporate PR feedback

owid · Sep 4, 2024 · ede005b · ede005b
1 parent b701e8f
commit ede005b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/adminSiteServer/chartConfigR2Helpers.ts b/adminSiteServer/chartConfigR2Helpers.ts
@@ -36,14 +36,14 @@ const getS3Client: () => S3Client = lazy(
 )
 
 export async function saveGrapherConfigToR2ByUUID(
-    id: string,
+    uuid: string,
     chartConfigStringified: string,
     configMd5FromDb: Base64String
 ) {
     await saveGrapherConfigToR2(
         chartConfigStringified,
         R2GrapherConfigDirectory.byUUID,
-        `${id}.json`,
+        `${uuid}.json`,
         configMd5FromDb
     )
 }

diff --git a/devTools/syncGraphersToR2/syncGraphersToR2.ts b/devTools/syncGraphersToR2/syncGraphersToR2.ts
@@ -126,8 +126,8 @@ async function syncWithR2(
 
     // Delete the files in R2 that are no longer needed
     await pMap(
-        [...hashesOfFilesToDelete.entries()],
-        async ([key, _]) => {
+        [...hashesOfFilesToDelete.keys()],
+        async (key) => {
             const deleteObjectCommandInput: DeleteObjectCommandInput = {
                 Bucket: GRAPHER_CONFIG_R2_BUCKET,
                 Key: key,

diff --git a/packages/@ourworldindata/utils/src/Util.test.ts b/packages/@ourworldindata/utils/src/Util.test.ts
@@ -795,4 +795,3 @@ describe(formatInlineList, () => {
         )
     })
 })
-//
-Original file line number
+Diff line change
@@ Expand Up / @@ -795,4 +795,3 @@ describe(formatInlineList, () => { @@
             )
         })
     })
-    //