Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datapages do not render without Javascript #2992

Closed
Tracked by #3562
ikesau opened this issue Dec 5, 2023 · 4 comments · Fixed by #3667
Closed
Tracked by #3562

Datapages do not render without Javascript #2992

ikesau opened this issue Dec 5, 2023 · 4 comments · Fixed by #3667

Comments

@ikesau
Copy link
Member

ikesau commented Dec 5, 2023

Found while investigating the archive.org issue:

image

Our regular grapher pages still work:

image

@ikesau
Copy link
Member Author

ikesau commented Dec 5, 2023

Similarly, static collections do not work without JS.

We should make something similar to Grapher.renderSingleGrapherOnGrapherPage

i.e. GrapherFigure, which can SSR the figure and fallback img

@mlbrgl
Copy link
Member

mlbrgl commented Feb 8, 2024

Similarly grapher charts are not rendered in gdocs w/o JS

with JS

Screenshot 2024-02-08 at 18 13 32

without JS

Screenshot 2024-02-08 at 18 13 00

@mlbrgl
Copy link
Member

mlbrgl commented Feb 15, 2024

Consider expanding getChartEmbedUrlsInPublishedWordpressPosts to include embeds from gdocs posts if we want to bake them the same way as embeds from Wordpress posts (see #3182 (comment))

@danyx23
Copy link
Contributor

danyx23 commented Mar 12, 2024

This seems related to #2354 and we think that one should be fixed first. On top of that one this one is probably only a day of work? Seems important though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants