Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleMarkdownText with SSR #3667

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix SimpleMarkdownText with SSR #3667

merged 1 commit into from
Jun 6, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented May 30, 2024

I looked into moving markdown rendering to the server, but dropped it because it would increase the scope too much.

Fixes #2992

@rakyi rakyi requested a review from ikesau May 30, 2024 08:30
@owidbot
Copy link
Contributor

owidbot commented Jun 3, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-markdown-ssr

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-03 12:32:26 UTC
Execution time: 1.17 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@rakyi rakyi merged commit 6235b06 into master Jun 6, 2024
21 checks passed
@rakyi rakyi deleted the markdown-ssr branch June 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datapages do not render without Javascript
3 participants