Explorers: Indicators are shown more than once in the same chart

[lucasrodes]

Description

For some explorer views, the same indicator (its time-series, legend name, etc) is shown more than once. I think this may only be happening for catalogPath-based explorers.

Expected

Indicators should be shown only once.

Context and Examples

Issue first raised by Bastian (https://github.com/owid/owid-issues/issues/1650#issuecomment-2338126422), then reported on Slack.

Conflict explorer

View

I also realised that if I switch between views (and keep doing it), the indicators are added again, and again, ...

Population & demography explorer

View

Migration explorer

View

Steps to reproduce

1. Go to https://ourworldindata.org/explorers/migration
2. Switch to 'Chart' view. You'll see indicators repeated for each country.

Optional:

3. Then select another option from the drop-down menu, e.g. 'International immigrants'
4. Then select back the initial drop-down option 'International emigrants'. You'll see indicators added a third time for each country.

Environment

For desktop, provide:

• OS: Linux (Arch Manjaro)
• Browser: Firefox
• Version: 125.0.1-1

[danyx23]

In this slack conversation, Ike found this source of the bug:

In Explorer.tsx, the partialGrapherConfig for 812749 has 812749 twice in its dimensions. (edited)
The duplicate is getting pushed in here:

owid-grapher/explorer/Explorer.tsx

Line 593 in 9c1a2a2

yVariableIdsList.forEach((yVariableId) => {

So one fix would be to not push duplicates from yVariableIdsList into dimensions,

[lucasrodes]

@larsyencken should we consider this fixed?

cc. @ikesau