Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Don't trigger lightning updates if dod document is updated #2863

Merged
merged 1 commit into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions adminSiteClient/gdocsDeploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
omit,
} from "@ourworldindata/utils"
import { GDOC_DIFF_OMITTABLE_PROPERTIES } from "./GdocsDiff.js"
import { GDOCS_DETAILS_ON_DEMAND_ID } from "../settings/clientSettings.js"

export const checkFullDeployFallback = (
prevGdoc: OwidGdocInterface,
Expand Down Expand Up @@ -103,6 +104,7 @@ export const checkIsLightningUpdate = (
const nextOmitted = omit({ ...nextGdoc }, keysToOmit)

return (
prevGdoc.id !== GDOCS_DETAILS_ON_DEMAND_ID &&
hasChanges &&
prevGdoc.published &&
nextGdoc.published &&
Expand Down
3 changes: 3 additions & 0 deletions settings/clientSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,6 @@ export const IMAGE_HOSTING_BUCKET_SUBFOLDER_PATH: string =
// Fast-track settings, by default points to staging version. You need Tailscale to access it.
export const FASTTRACK_URL: string =
process.env.FASTTRACK_URL ?? "http://owid-analytics:8083/"

export const GDOCS_DETAILS_ON_DEMAND_ID: string =
process.env.GDOCS_DETAILS_ON_DEMAND_ID ?? ""
Loading