Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install packages only when relevant files change #3606

Merged
merged 2 commits into from
May 16, 2024
Merged

Install packages only when relevant files change #3606

merged 2 commits into from
May 16, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented May 15, 2024 •
edited
Loading

node_modules is an existing target, that depends on changes to package.json, yarn.lock and yarn.config.cjs to run yarn install.

@rakyi rakyi requested a review from mlbrgl May 15, 2024 13:34
@owidbot
Copy link
Contributor

owidbot commented May 15, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-improve-yarn-install-with-make

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 0

Edited: 2024-05-15 13:43:19 UTC
Execution time: 1.17 seconds

marcelgerber
marcelgerber approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rakyi rakyi merged commit 8c7af45 into master May 16, 2024
32 checks passed
@rakyi rakyi deleted the improve-yarn-install-with-make branch May 16, 2024 14:53
mlbrgl
mlbrgl reviewed May 16, 2024
View reviewed changes
Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! That make.up is so fast now, wow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlbrgl mlbrgl mlbrgl left review comments

@marcelgerber marcelgerber marcelgerber approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakyi @owidbot @marcelgerber @mlbrgl