Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (line labels) increase height of the line legend / TAS-507 #3658

Merged
merged 1 commit into from
Jun 11, 2024
Merged

✨ (line labels) increase height of the line legend / TAS-507 #3658

merged 1 commit into from
Jun 11, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 28, 2024 •
edited
Loading

Increases the height of the line legend to both sides. The line legend used to be as tall as the y-axis. Now the line legend uses the full extent of the chart. On smaller screens, a larger height can give us an additional label, see below 👇🏻

Before After
334457762-5f2cf38c-1419-47af-a4b8-085e39c718e6 Screenshot 2024-05-28 at 16 15 55

@sophiamersmann sophiamersmann mentioned this pull request May 28, 2024
Merged
@sophiamersmann Graphite App
Copy link
Member Author

sophiamersmann commented May 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@sophiamersmann sophiamersmann changed the title ✨ (line labels) increase height of the line legend ✨ (line labels) increase height of the line legend / TAS-507 May 28, 2024
@notion-workspace Notion Workspace
Copy link

Increase height of the line legend

@sophiamersmann sophiamersmann marked this pull request as ready for review May 28, 2024 13:40
@sophiamersmann sophiamersmann marked this pull request as draft May 28, 2024 13:40
@owidbot
Copy link
Contributor

owidbot commented May 28, 2024 •
edited
Loading

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-line-legend-height

SVG tester:

Number of differences (default views): 1237 (4e9cd3) ❌
Number of differences (all views): 425 (54ab5d) ❌

Edited: 2024-06-11 09:34:10 UTC
Execution time: 1.21 seconds

@sophiamersmann sophiamersmann force-pushed the line-legend-height branch 2 times, most recently from 379ef20 to cf94aad Compare May 28, 2024 14:01
@sophiamersmann sophiamersmann force-pushed the line-legend-height branch 2 times, most recently from c40c9f9 to 4099b63 Compare May 28, 2024 14:21
@sophiamersmann sophiamersmann marked this pull request as ready for review May 29, 2024 09:48
@sophiamersmann Graphite App
Copy link
Member Author

sophiamersmann commented Jun 11, 2024 •
edited
Loading

Merge activity

Base automatically changed from line-legend-algo to master June 11, 2024 09:49
@sophiamersmann sophiamersmann merged commit abd34be into master Jun 11, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the line-legend-height branch June 11, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiamersmann sophiamersmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiamersmann @owidbot