🔨 extract LabeledSwitch
into components library
#3850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this thing for the data catalog, and didn't want to bog that PR down with a dependency refactor 🙂
The SCSS was scoped pretty aggressively to
It's the only component we have with the class name
labeled-switch
- so my first instinct is that it's safe to lift this up. I've also gone through and checked each of the places it's used:TableFilterToggle.tsx
https://github.com/user-attachments/assets/d916b9bd-c613-47a7-b3b3-522d60a4aaec
FacetYDomainToggle.tsx
https://github.com/user-attachments/assets/263aa2bd-3ebe-43fa-b136-5a3473464358
AbsRelToggle.tsx
https://github.com/user-attachments/assets/9d2cdf3a-b12d-4a48-871f-06f32144dbe7
ZoomToggle.tsx
https://github.com/user-attachments/assets/e21a0686-86dc-4a7c-aa8e-fb1603eeb9eb
NoDataAreaToggle.tsx
Where do we show this? 😀