Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't animate initially-open key indicator height #3864

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Aug 12, 2024

Fixes #3863 by omitting the explicit height: 0px during server-side rendering.

This makes it so the first section of the collection is open by default, without a height animation.

@owidbot
Copy link
Contributor

owidbot commented Aug 12, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-key-indicators-height

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-12 09:42:28 UTC
Execution time: 1.19 seconds

Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes the issue ✅ Thanks a lot!

@marcelgerber marcelgerber merged commit bd932ed into master Aug 12, 2024
27 checks passed
@marcelgerber marcelgerber deleted the key-indicators-height branch August 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key indicator collection is messing up anchor links on the home page
3 participants