Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct, absolute URL for grapher exports #3882

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Aug 19, 2024

Fixes #3881.

I also renamed that method, so that it now actually says what it does.

@owidbot
Copy link
Contributor

owidbot commented Aug 19, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-svg-export-grapher-url

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-19 16:13:27 UTC
Execution time: 1.24 seconds

@marcelgerber marcelgerber force-pushed the fix-svg-export-grapher-url branch from 3590d2b to 8906be9 Compare August 19, 2024 16:06
@marcelgerber marcelgerber marked this pull request as ready for review August 19, 2024 16:14
@marcelgerber marcelgerber merged commit d29f58f into master Aug 19, 2024
20 checks passed
@marcelgerber marcelgerber deleted the fix-svg-export-grapher-url branch August 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baked SVGs use relative URLs for /grapher/ and /fonts.css links
2 participants