perf: sort table less often & re-use columnStore if unchanged
#3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-28 21:34:10 UTC |
marcelgerber
force-pushed
the
table-sort-perf
branch
from
8cebae5 to
40ff2b2
Compare
marcelgerber
force-pushed
the
table-sort-perf
branch
from
fc4aec1 to
54bed93
Compare
marcelgerber
force-pushed
the
table-sort-perf
branch
from
54bed93 to
ae53562
Compare
marcelgerber
changed the title
OwidTable.sortColumnStorecolumnStore if unchanged
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm curious about the SVG Tester runs here 👀
These improvements should make a sizeable perf & memory consumption improvement, and ideally not break things. We'll see :)
I tested these on https://ourworldindata.org/grapher/covid-daily-vs-total-cases-per-million.