🐛 (admin) mark unpublished charts as drafts

[sophiamersmann]

• Fixes a regression in the admin where unpublished charts weren't marked as "draft" in the admin's chart list
• This happened because the admin expected isPublished to be a boolean when really it was a string value that is either "true" or "false"
• This went unnoticed before having full configs because isPublished used to be either null (falsy) or "true" (truthy)
• I'm a bit surprised that these are parsed as strings by knex, maybe there is a deeper issue to fix? The db looks fine though, as far as I can see

[sophiamersmann]

• 🐛 (admin) mark unpublished charts as drafts #3923 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-fix-admin-drafts

• Site-screenshots: https://github.com/owid/site-screenshots/compare/fix-admin-drafts
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/fix-admin-drafts

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-04 09:46:16 UTC
Execution time: 1.16 seconds

[danyx23]

Probably the nicer way to do this is to change how isPublished is queried in the oldChartFieldList so that it works like hasMapTab. The reason for this behaviour is that we don't have json auto-parsing enabled in mysql2 so if you query a json value we get it's string representation that we manually have to query. The JSON_EXTRACT(chart_configs.full, "$.hasChartTab") = true AS hasChartTab clause (could also be done with ->> though of course) then makes sure that the value we get from mysql is a boolean and them mysql2 can just give back that boolean

[sophiamersmann]

ah yes, that makes a lot of sense. i was really confused by this