🐛 (grapher) delete stackMode=null from chart configs #3926
Merged
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
force-pushed
the
cleanup-stack-mode-null
branch
from
32a948d to
5037f76
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-09-05 13:17:32 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3793, I removed
nullas an option from the Grapher schema. I thought I checked that we didn't have any nulls in the database, but apparently, I was wrong (see the validation error in Slack). This PR writes a migration to remove nulls from the database. I'm only doing this for chart configs since none of our indicator charts has thestackModeset to null.I don't think null values currently have a way to get into the database. But if it happens, the validator will warn us again, and we can act then.