Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active state to admin nav #3929

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Add active state to admin nav #3929

merged 1 commit into from
Sep 5, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Sep 5, 2024 •
edited
Loading

I thought it would be nice to make it easier for users to see where they are in the admin.

image

@rakyi rakyi requested a review from sophiamersmann September 5, 2024 15:53
@owidbot
Copy link
Contributor

owidbot commented Sep 5, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-active-admin-nav

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-05 16:02:23 UTC
Execution time: 1.26 seconds

sophiamersmann
sophiamersmann approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rakyi rakyi merged commit 6bc238b into master Sep 5, 2024
27 checks passed
@rakyi rakyi deleted the active-admin-nav branch September 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiamersmann sophiamersmann sophiamersmann approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakyi @owidbot @sophiamersmann