Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix PNG assumption in AtomArticleBlocks #3932

Merged
merged 1 commit into from
Sep 6, 2024
Merged

🐛 fix PNG assumption in AtomArticleBlocks #3932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion site/gdocs/components/AtomArticleBlocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ function Image({
? Math.round(LARGEST_IMAGE_WIDTH / aspectRatio)
: undefined

const extension = getFilenameExtension(image.filename)
// If we're using a resized image (i.e. it has a width suffix), the file extension is ALWAYS png
// If we're using the original image, we need to check the original file extension (which SHOULD be png, but might not be)
const extension = widthSuffix ? "png" : getFilenameExtension(filename)

return (
<img
src={`${BAKED_BASE_URL}${IMAGES_DIRECTORY}${filenameWithoutExtension}${widthSuffix}.${extension}`}
Expand Down