Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add admin image validation for data insights #3933

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Sep 6, 2024

A follow-up to #3932 to ensure authors don't mistakenly upload images in the wrong file format.

Made non-PNGs a warning because there's still a plausible case where JPEG is better for a custom graphic... maybe 🙊

@ikesau ikesau requested a review from rakyi September 6, 2024 17:43
@ikesau ikesau self-assigned this Sep 6, 2024
@owidbot
Copy link
Contributor

owidbot commented Sep 6, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-data-insight-image-validation

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-06 17:52:01 UTC
Execution time: 1.21 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ikesau ikesau merged commit 07db948 into master Sep 9, 2024
27 checks passed
@ikesau ikesau deleted the data-insight-image-validation branch September 9, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants