Update 404 page to the new design #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rakyi
commented
Sep 10, 2024
rakyi
commented
rakyi
force-pushed
the
new-not-found-page
branch
from
5da9d3a to
e672145
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-09-10 10:59:53 UTC |
ikesau
approved these changes
Sep 12, 2024
| </form> | ||
| <p className="body-2-semibold"> | ||
| You can search for what you were hoping to find below or{" "} | ||
| <a href="/">visit our homepage</a>. |
There was a problem hiding this comment.
This link is missing a hover style - is it meant to be owid-link-90 ? (we should probably add a util class for that mixin, like we do for typography)
There was a problem hiding this comment.
Almost, it should be blue-60 color. I'll still use the mixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.