Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 initialize markdown at gdoc creation #4160

Closed
wants to merge 1 commit into from

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Nov 13, 2024

Lucas noticed that some unpublished data insights don't have content in the markdown column - this PR should make sure that going forward the markdown column is filled.

It would be good to also add a migration for the ones that are missing markdown but I don't have time for that rn

@owidbot
Copy link
Contributor

owidbot commented Nov 13, 2024

Quick links (staging server):

Site Admin Wizard Docs

Login: ssh owid@staging-site-set-markdown-at-gdoc-creation

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-13 13:07:21 UTC
Execution time: 1.19 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is working - my markdown column stays null when I publish or update an article. I think it's not getting called in the PUT code path.

Copy link

github-actions bot commented Dec 4, 2024

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Dec 4, 2024
@github-actions github-actions bot closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants