Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable extended tooltip hover area #4161

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: re-enable extended tooltip hover area #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ export class LineChart
{/* The tiny bit of extra space in the clippath is to ensure circles
centered on the very edge are still fully visible */}
{this.clipPath.element}
<rect {...this.bounds.toProps()} fill="none">
<rect {...this.bounds.toProps()} fillOpacity="0">
{/* This <rect> ensures that the parent <g> is big enough such that
we get mouse hover events for the whole charting area, including
the axis, the entity labels, and the whitespace next to them.
Expand Down
2 changes: 1 addition & 1 deletion packages/@ourworldindata/grapher/src/stackedCharts/StackedAreaChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ export class StackedAreaChart
onTouchMove={this.onCursorMove}
>
{clipPath.element}
<rect {...this.bounds.toProps()} fill="none">
<rect {...this.bounds.toProps()} fillOpacity="0">
{/* This <rect> ensures that the parent <g> is big enough such that we get mouse hover events for the
whole charting area, including the axis, the entity labels, and the whitespace next to them.
We need these to be able to show the tooltip for the first/last year even if the mouse is outside the charting area. */}
Expand Down