Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donate updates #4167

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Donate updates #4167

merged 3 commits into from
Nov 15, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Nov 14, 2024

As requested by Charlie and Hassan.

I tested the changes locally, following the instructions in the README.

Fixes #4133

@rakyi rakyi requested a review from ikesau November 14, 2024 15:12
@rakyi rakyi force-pushed the donate-updates branch 2 times, most recently from d52301b to 975a9e5 Compare November 14, 2024 15:19
@owidbot
Copy link
Contributor

owidbot commented Nov 14, 2024

Quick links (staging server):

Site Admin Wizard Docs

Login: ssh owid@staging-site-donate-updates

SVG tester:

Number of differences (default views): 134 (fade59) ❌
Number of differences (all views): 174 (982c2b) ❌

Edited: 2024-11-14 15:42:51 UTC
Execution time: 1.22 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't test it, but read every line thoroughly to check for spelling mistakes and formatting errors.

functions/donation/thank-you.ts Outdated Show resolved Hide resolved
functions/donation/thank-you.ts Outdated Show resolved Hide resolved
* Update copy
* Add HTML version
@rakyi rakyi merged commit b6a6bce into master Nov 15, 2024
12 of 13 checks passed
@rakyi rakyi deleted the donate-updates branch November 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycle 2024.7: Donation improvements
3 participants