🎉 Explorers index page #4175
Merged
🎉 Explorers index page #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-11-15 16:29:56 UTC |
ikesau
force-pushed
the
explorer-index-page
branch
from
0d8e9f1 to
c4c196d
Compare
rakyi
approved these changes
Nov 27, 2024
| knex: KnexReadonlyTransaction | ||
| ): Promise<string> => { | ||
| const explorersBySlug = await getPublishedExplorersBySlug(knex) | ||
| const explorers = Object.values(explorersBySlug).sort((a, b) => |
There was a problem hiding this comment.
Doesn't really matter here, but in general it's usually better for perf to do the sorting in the DB in the same query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple explorer index page that a few of us at OWID have been missing. It also gives the homepage "See all our Data Explorers" link somewhere useful to go to.
We'll possibly update these cards to look the same as the cards on the homepage once Marwa has some time to design the rest of the tag icons that we'd need.