Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore correct ellipsis word wrap for sources modal #4186

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: restore correct ellipsis word wrap for sources modal #4186

merged 1 commit into from
Nov 19, 2024

Conversation

marcelgerber
Copy link
Member

Fixes #4180 by restoring the span to the default display: inline.

@owidbot
Copy link
Contributor

owidbot commented Nov 19, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-source-modal-tab-ellipsis

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-19 12:55:36 UTC
Execution time: 1.23 seconds

@marcelgerber marcelgerber merged commit c28ede3 into master Nov 19, 2024
27 checks passed
@marcelgerber marcelgerber deleted the source-modal-tab-ellipsis branch November 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiamersmann sophiamersmann sophiamersmann approved these changes

Assignees

@marcelgerber marcelgerber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truncated sources tab don't render short attribution
3 participants
@marcelgerber @owidbot @sophiamersmann