-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donation campaign updates #4226
Conversation
rakyi
commented
Nov 27, 2024
•
edited
Loading
edited
fccf1e9
to
4ffd576
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-11-27 12:30:02 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Do we want to hide the big banner on the /donate
page itself?
@@ -163,6 +166,8 @@ export class DonateForm extends React.Component { | |||
) | |||
} | |||
|
|||
analytics.logSiteFormSubmit("donate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to log an event for errors (both client-side validation and server-side responses)? Can't hurt, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not what we usually do, right? And I don't think it's very valuable to know how many errors we get here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ultimately your choice, of course.
But it could allow for some interesting insights, like "how many people gave up after getting a validation error, and how many tried again to get it right?" (this is, obviously, with the big caveat that people can also give up at a later stage, in the Stripe payment portal).
4ffd576
to
ad553c7
Compare
Good idea, added that. |