Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation campaign updates #4226

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Donation campaign updates #4226

merged 3 commits into from
Nov 27, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Nov 27, 2024

image

@owidbot
Copy link
Contributor

owidbot commented Nov 27, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-donate-campaign

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-27 12:30:02 UTC
Execution time: 1.29 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Do we want to hide the big banner on the /donate page itself?

@@ -163,6 +166,8 @@ export class DonateForm extends React.Component {
)
}

analytics.logSiteFormSubmit("donate")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to log an event for errors (both client-side validation and server-side responses)? Can't hurt, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not what we usually do, right? And I don't think it's very valuable to know how many errors we get here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ultimately your choice, of course.
But it could allow for some interesting insights, like "how many people gave up after getting a validation error, and how many tried again to get it right?" (this is, obviously, with the big caveat that people can also give up at a later stage, in the Stripe payment portal).

@rakyi
Copy link
Contributor Author

rakyi commented Nov 27, 2024

Do we want to hide the big banner on the /donate page itself?

Good idea, added that.

@rakyi rakyi merged commit e56ee78 into master Nov 27, 2024
21 checks passed
@rakyi rakyi deleted the donate-campaign branch November 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants