Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdoc component extraction #4314

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix gdoc component extraction #4314

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
155077f
🐛 fix bug in gdoc component extraction code
danyx23 Dec 16, 2024
694f430
Update extractGdocComponentInfo.ts
danyx23 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions db/model/Gdoc/extractGdocComponentInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,15 @@ function iterateArrayProp<T extends OwidEnrichedGdocBlock>(
parentPath: string,
prop: keyof T
): ChildIterationInfo[] {
return (parent[prop] as OwidEnrichedGdocBlock[]).map((child, index) => ({
child: child,
parentPath: `${parentPath}`,
path: `${parentPath}.${String(prop)}[${index}]`,
}))
if (prop in parent)
danyx23 marked this conversation as resolved.
Show resolved Hide resolved
return (parent[prop] as OwidEnrichedGdocBlock[]).map(
(child, index) => ({
child: child,
parentPath: `${parentPath}`,
path: `${parentPath}.${String(prop)}[${index}]`,
})
)
else return []
}

/** Convert the spans in a gdoc component to plain text.
Expand Down
Loading