✨ (map) left-align multi-line categorical legends #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 88 (d0a844) ❌ Edited: 2024-12-17 11:31:35 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3988 by left-aligning categorical map legends when they have more than one line.
Introduces a bit of a regression, where the left/right padding around legend is removed (see second screenshot below). The padding has to be zero when the legend is left-aligned, but I can't add a condition to the code to that effect since that would introduce a cyclic dependency (to know whether to left-align the legend, I need to know the number of lines, and to know the number of lines, I need to know the
maxLegendWidth).