Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Load next messages automatically when reaching end of the list #1432

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

ChristophWurst
Copy link
Contributor

fixes #499

@Gomez @jancborchardt @skjnldsv review please

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Gomez to be a potential reviewer

@jancborchardt
Copy link
Contributor

Nice! 👍

Only thing is I see an error in the owncloud.log:

Argument 1 passed to OCA\\Mail\\Model\\IMAPMessage::hordeToAssoc()
must be an instance of Horde_Mail_Rfc822_Address, instance of Horde_Mail_Rfc822_Group given,
called in \/home\/jan\/owncloud\/apps\/mail\/lib\/model\/convertaddresses.php
on line 73
and defined at \/home\/jan\/owncloud\/apps\/mail\/lib\/model\/convertaddresses.php#33"

Also if we do lazy loading, we can remove the button from the bottom there and replace it with just a large centered spinner directly in the list.

@ChristophWurst
Copy link
Contributor Author

Also if we do lazy loading, we can remove the button from the bottom there and replace it with just a large centered spinner directly in the list.

Yes, let's do that in a follow up PR ;-)

@ChristophWurst ChristophWurst merged commit f2e9fc9 into master Apr 20, 2016
@ChristophWurst ChristophWurst deleted the infinite-scrolling branch April 20, 2016 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants