Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Make accounts collapsable and show only important folders #1445

Merged
merged 1 commit into from
Apr 25, 2016

Conversation

ChristophWurst
Copy link
Contributor

fixes #677

Suggestions on what folders are to be considered important und should be shown even when the account is collapsed are welcome.

We can think about automatically hiding drafts if there are none, but as long as the client-side is not always up to date with the server state I'd like to not add that enhancement yet and wait until we have solved that cleanly.

@jancborchardt I'm afraid this is very badly discoverable. Any idea how to solve that?

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @jancborchardt, @DeepDiver1975 and @Gomez to be potential reviewers

@jancborchardt
Copy link
Contributor

So far it doesn’t seem to collapse anything? Like Trash, Sent, Spam, all custom folders, (and maybe Drafts) should definitely be hidden by default.

@ChristophWurst
Copy link
Contributor Author

It works for me:

Collapsed state (default):
bildschirmfoto von 2016-04-24 12-05-49
Expanded state:
bildschirmfoto von 2016-04-24 12-05-58

Maybe it's a caching issue, try ctrl+F5

@ChristophWurst
Copy link
Contributor Author

ChristophWurst commented Apr 24, 2016

Works on FF and Chromium

@jancborchardt
Copy link
Contributor

Arrrgh … again seemed to be a caching issue. ;) Works fine, and very nice! :)

Instead of clicking the account name to expand it (that should actually open the menu #1446), I would say there should be one more line saying »Show all folders …«. On the bottom, at 50% opacity which triggers the folders. Because that’s more related as the folders are shown below the important ones.

Then ideally there should also be a short animation to have some feedback of what’s happening, and the »Show all folders …« thing can change to »Collapse folders …«.

@ChristophWurst
Copy link
Contributor Author

@jancborchardt thanks a lot for your feedback. I updated the commit according to your suggestions:
bildschirmfoto von 2016-04-24 13-25-19

An animation can be added later, I'll have to think about how to do that properly.

@jancborchardt
Copy link
Contributor

Nice! The line-height / padding is off a bit, that is between drafts and show all folders there's less space than between the othets. Is it a li as well? If not, should get the same padding values as the lis.

@ChristophWurst
Copy link
Contributor Author

Good catch, I fixed the css. No, it's not a li so I had to manually apply margin to align it with the other navigation entries.

@ChristophWurst
Copy link
Contributor Author

Looks better now:
bildschirmfoto von 2016-04-24 15-12-45

@jancborchardt
Copy link
Contributor

Nice, 👍!

@ChristophWurst ChristophWurst merged commit 5d6bb00 into master Apr 25, 2016
@jancborchardt jancborchardt deleted the collapse-account branch April 25, 2016 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants