OAuth2 #474
Merged
OAuth2 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Basically, it introduces 3 new test-cases: - Switching the URL after connection, - OAuth2 multi-tenancy installations ... And modifies one: 'Basic Auth. multi-tenancy setup' [Regression]. It also adds a couple of missing col.delimiters on the tables.
It includes status of all TC executed so far.
See owncloud/oauth2#47 for reference
SamuAlfageme
requested changes
Aug 14, 2017
| | 2 | OAuth2 URL http | 1. Set an URL of a http server with OAuth2<br>2. Tap on connect.<br> Check both orientations | Redirected to webview. No more options shown | | | | ||
| | 3 | OAuth2 URL https trusted | 1. Set an URL of a https trusted server with OAuth2<br>2. Tap on connect.<br> Check both orientations | Redirected to webview. No more options shown | | | | ||
| | 4 | OAuth2 URL https non-trusted | 1. Set an URL of a https non-trusted server with OAuth2<br>2. Tap on connect.<br> Check both orientations | Redirected to webview. No more options shown | | | | ||
| | 5 | Basic Auth http URL | 1. Set an URL of a http server without OAuth2<br>2. Tap on connect.<br>Check both orientations | Fields username and password are shown | | | |
There was a problem hiding this comment.
@jesmrec missing a couple of 'Edit the URL after clicking on connection to check for the switch on the auth. method' for both methods. e.g.:
- After tapping on connect, on basic auth. change the URL to point an OAuth-supporting server.
- Closing the OAuth2 webview and editing the URL to point a server not supporting OAuth.
Will add them.
| | 5 | Basic Auth http URL | 1. Set an URL of a http server without OAuth2<br>2. Tap on connect.<br>Check both orientations | Fields username and password are shown | | | | ||
| | 6 | Basic Auth https trusted URL | 1. Set an URL of a https trusted server without OAuth2<br>2. Tap on connect.<br>Check both orientations | Fields username and password are shown | | | | ||
| | 7 | Basic Auth https non-trusted URL | 1. Set an URL of a https non-trusted server without OAuth2<br>2. Tap on connect.<br>Check both orientations | Fields username and password are shown | | | | ||
| | 8 | Redirected URL | 1. Set a redirection URL <br>2. Tap on connect. <br>Check both orientations | Fields username and password are shown | | |
There was a problem hiding this comment.
We're missing a multi-tenancy setup like the one in https://github.com/owncloud/administration/tree/master/redirectServer for an OAuth instance, I will try to reproduce one and add a new TC.
This one will be adapted to 'Redirected URL on Basic Auth. server'
… .apk with fixes.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.