Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the SplashScreen API #3391

Open
8 of 9 tasks
abelgardep opened this issue Sep 24, 2021 · 6 comments · May be fixed by #3421
Open
8 of 9 tasks

Migrate to the SplashScreen API #3391

abelgardep opened this issue Sep 24, 2021 · 6 comments · May be fixed by #3421
Labels
Estimation - 3 (M) Feature request Needs info p3-medium Normal priority
Milestone
4.5 - Current

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Sep 24, 2021 •
edited by jesmrec
Loading

With Android 12, a new Splash Screen API was introduced. We should migrate it from the custom to the new API to ensure that it displays correctly starting in Android 12

TASKS

  • Research (if needed)
  • Create branch feature/migrate_splash_screen
  • Development tasks
    • Implement new API
    • Add compatibility with older Android versions
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/migrate_splash_screen into master

PR
@jesmrec jesmrec added this to the 2.20-next milestone Sep 30, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 1, 2021

To check if helps to fix https://github.com/owncloud/enterprise/issues/4727

@jesmrec jesmrec added the Sprint label Oct 22, 2021
@nathanmkaya
Copy link

@jesmrec @abelgardep @fesave could I pick this up?

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 25, 2021 •
edited
Loading

@nathanmkaya we have already started to work on this, so, in order to avoid duplicated PRs, i suggest you to use the "Contributions are welcome" label to filter issues that are interesting to contribute. Also, if you have in mind any issue or new feature, it is welcome as new issue as well.

Thanks a lot for your engagement!

@fesave fesave linked a pull request Oct 26, 2021 that will close this issue
Open
1 task
@fesave
Copy link
Contributor

fesave commented Oct 26, 2021 •
edited
Loading

With the new home screen API for Android 12 devices, I tried to reproduce the owncloud/enterprise#4727 as you can see in the video and it was impossible, I think we are on the right way to fix it.

cc @michaelstingl

android_record.mov

@fesave fesave linked a pull request Oct 26, 2021 that will close this issue
[FEATURE] Migrate splash screen #3421
Open
1 task
@michaelstingl
Copy link
Contributor

I think we are on the right way to fix it.

Glad to hear 👍

@jesmrec jesmrec removed the Sprint label Dec 3, 2021
@jesmrec jesmrec modified the milestones: 2.20-current, -next Feb 3, 2022
@fesave fesave modified the milestones: 2.21-current, 2.22-next Apr 29, 2022
@michaelstingl michaelstingl added the p3-medium Normal priority label Apr 13, 2023
@michaelstingl
Copy link
Contributor

Check again with the final version?

@jesmrec jesmrec modified the milestones: 4.1 - Next, 4.2 - Future Jun 12, 2023
@jesmrec jesmrec mentioned this issue Mar 4, 2024
Open
@JuancaG05 JuancaG05 modified the milestones: 4.3 - Current, 4.4 - Future May 3, 2024
@jesmrec jesmrec modified the milestones: 4.4 - Current, 4.5 - Next Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimation - 3 (M) Feature request Needs info p3-medium Normal priority
Projects
None yet
Milestone
4.5 - Current
Development

Successfully merging a pull request may close this issue.

[FEATURE] Migrate splash screen owncloud/android
6 participants
@michaelstingl @nathanmkaya @jesmrec @abelgardep @fesave @JuancaG05