Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Migrate splash screen #3421

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[FEATURE] Migrate splash screen #3421

wants to merge 5 commits into from

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Oct 26, 2021 •
edited
Loading

Related Issues

App: #3391

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

@fesave fesave self-assigned this Oct 26, 2021
@fesave fesave mentioned this pull request Oct 26, 2021
Open
9 tasks
@fesave fesave linked an issue Oct 26, 2021 that may be closed by this pull request
Migrate to the SplashScreen API #3391
Open
9 tasks
@fesave fesave marked this pull request as ready for review October 26, 2021 14:17
JuancaG05
JuancaG05 requested changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny change only! Good job @fesave 👍

changelog/unreleased/3421 Outdated Show resolved Hide resolved
@fesave fesave force-pushed the feature/migrate_splash_screen branch from f85e7db to 045522b Compare November 2, 2021 07:18
@fesave fesave requested a review from JuancaG05 November 2, 2021 07:19
@fesave fesave force-pushed the feature/migrate_splash_screen branch from d64fbb4 to 5ba4eeb Compare November 3, 2021 07:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 18, 2021

Splash screen is correctly built with the new API for Android 12 versions (tested with emulator)

New splash screen is built with the white cloud icon and the dark-blue background. The word ownCloud, present in the app icon displayed in the login view, is not part of the splash screen anymore.

OTOH, by checking the attached Android documentation, this feature is still in alpha version:

https://developer.android.com/guide/topics/ui/splash-screen/migrate

so, it's not totally safe to merge it. We could either wait till 2.20 is frozen, just in case it jumps to a stable version, or delay it a bit more till Google makes it stable.

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 13, 2022

released:

androidx.core:core-splashscreen:1.0.0-beta01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@fesave fesave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to the SplashScreen API
3 participants
@fesave @jesmrec @JuancaG05