Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidx.appcompat:appcompat from 1.5.1 to 1.6.1 #3904

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 9, 2023

Bumps androidx.appcompat:appcompat from 1.5.1 to 1.6.1.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Feb 9, 2023
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 5 times, most recently from 950a0a1 to c48cd06 Compare February 14, 2023 15:08
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 3 times, most recently from 7fb325e to b7b5022 Compare February 24, 2023 12:07
@abelgardep
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 3 times, most recently from 1fc9aae to f3c01db Compare March 2, 2023 08:46
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 4 times, most recently from 018e261 to 1e359c9 Compare March 14, 2023 15:53
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 3 times, most recently from efee4be to 9b1830c Compare March 23, 2023 19:29
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 2 times, most recently from 13b4b1a to b90827b Compare April 10, 2023 07:18
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from b90827b to c0829dc Compare April 14, 2023 12:57
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 20, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from c0829dc to 3721c87 Compare March 20, 2024 10:49
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from 3721c87 to c8674e9 Compare April 16, 2024 14:00
@Aitorbp Aitorbp self-assigned this Apr 16, 2024
Bumps androidx.appcompat:appcompat from 1.5.1 to 1.6.1.

---
updated-dependencies:
- dependency-name: androidx.appcompat:appcompat
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from c8674e9 to 2e8458b Compare April 18, 2024 07:30
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch 3 times, most recently from 4d21841 to dc6933e Compare April 25, 2024 09:11
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from dc6933e to d8dce5c Compare April 25, 2024 11:05
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidx.appcompat-appcompat-1.6.1 branch from 550cabb to 1a78153 Compare April 26, 2024 09:09
…it_has_no_value and show_space_not_personal_when_it_has_value
@Aitorbp
Copy link
Contributor

Aitorbp commented Apr 30, 2024

Summary:

Too many test flakies when appcompat version is upgraded. The following scenarios have been tried to try to find a correct solution but it has not worked:

Putting delays:

I have tried putting delays in the tests to see the behavior. Based on the fact that it is not a good practice, the result has been negative, there were cases in which the tests were not even passed locally.

Create a rule in tests:

Since there is a significant number of flakies in each workflow, according to some documents you recommend creating a rule in the tests to re-execute those tests that have failed.
It has been tested locally and the tests pass perfectly but in Bitrise there is no notable improvement.
Create a test rule to repeat a test until it fails locally. I set the test to be repeated 100 times, but none of these iterations failed.
It should be noted that the local tests are not failing, so I understand that there must be a problem with Bitrise, which is where the flakies are appearing.

Bitrise:

An investigation has been done to see if Bitrise is closely related to this increase in flakies. For them the following scenarios have been tested:

  1. Increase the version of the Android emulator in Bitrise. It is currently in the NexusLowRes,28,en,portrait. It has been tried to go up to 30, since it is the maximum version that this emulator supports. The result has not been what was expected. Flaky tests have increased considerably.
    It has been tested by changing the emulator to SmallPhone.arm, setting version 32, which is also supported in our project. The result has not been what was expected either. Errors appeared in the tests of these classes. I tried with more device and it is not working neither.

  2. Use Orchestrator: According to the Bitrise documentation when you set Use Orchestrator input to true in the Step's Instrumentation Test section. This improves isolation between test cases, making your tests less likely to fail. You can see the benefits and drawbacks of Orchestrator here. But, no improvement has been observed, quite the contrary, the number of tests has increased.

@JuancaG05 JuancaG05 removed the Sprint label May 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 30, 2024

A newer version of androidx.appcompat:appcompat exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Estimation - 1 (XS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants