Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 11.1.4.3 Contrast (minimum) #4429

Merged
merged 14 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Table of Contents

* [Changelog for unreleased](#changelog-for-owncloud-android-client-unreleased-unreleased)
* [Changelog for 4.3.0](#changelog-for-owncloud-android-client-430-2024-07-01)
* [Changelog for 4.2.2](#changelog-for-owncloud-android-client-422-2024-05-30)
* [Changelog for 4.2.1](#changelog-for-owncloud-android-client-421-2024-02-22)
Expand All @@ -21,6 +22,27 @@
* [Changelog for 2.18.1](#changelog-for-owncloud-android-client-2181-2021-07-20)
* [Changelog for 2.18.0](#changelog-for-owncloud-android-client-2180-2021-05-24)
* [Changelog for 2.17 versions and below](#changelog-for-217-versions-and-below)
# Changelog for ownCloud Android Client [unreleased] (UNRELEASED)

The following sections list the changes in ownCloud Android Client unreleased relevant to
ownCloud admins and users.

[unreleased]: https://github.com/owncloud/android/compare/v4.3.0...master

## Summary

* Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)

## Details

* Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)

The color of some UI elements has been changed to meet minimum color contrast
requirements.

https://github.com/owncloud/android/issues/4364
https://github.com/owncloud/android/pull/4429

# Changelog for ownCloud Android Client [4.3.0] (2024-07-01)

The following sections list the changes in ownCloud Android Client 4.3.0 relevant to
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/4429
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Changed the color of some elements to improve accessibility

The color of some UI elements has been changed to meet minimum color contrast requirements.

https://github.com/owncloud/android/issues/4364
https://github.com/owncloud/android/pull/4429
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,10 @@ class FileListAdapter(
(view.itemView.layoutParams as StaggeredGridLayoutManager.LayoutParams).apply {
isFullSpan = true
}
view.binding.footerText.text = file.text
view.binding.footerText.apply {
text = file.text
setTextColor(ContextCompat.getColor(context, R.color.accessibility_grey_color))
JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,109 +45,14 @@ class ReleaseNotesViewModel(

companion object {
val releaseNotesList = listOf(
ReleaseNote(
title = R.string.release_notes_4_3_0_title_new_ui_manage_accounts,
subtitle = R.string.release_notes_4_3_0_subtitle_new_ui_manage_accounts,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_create_open_shortcut,
subtitle = R.string.release_notes_4_3_0_subtitle_create_open_shortcut,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_1,
subtitle = R.string.release_notes_4_3_0_subtitle_1,
type = ReleaseNoteType.ENHANCEMENT,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_2,
subtitle = R.string.release_notes_4_3_0_subtitle_2,
type = ReleaseNoteType.ENHANCEMENT,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_manual_removal_local_storage,
subtitle = R.string.release_notes_4_3_0_subtitle_manual_removal_local_storage,
type = ReleaseNoteType.ENHANCEMENT,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_password_generator,
subtitle = R.string.release_notes_4_3_0_subtitle_password_generator,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_report_feedback_central_github,
subtitle = R.string.release_notes_4_3_0_subtitle_report_feedback_central_github,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_clear_data_button_hard_reset,
subtitle = R.string.release_notes_4_3_0_subtitle_clear_data_button_hard_reset,
type = ReleaseNoteType.BUGFIX,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_4,
subtitle = R.string.release_notes_4_3_0_subtitle_4,
type = ReleaseNoteType.ENHANCEMENT,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_5,
subtitle = R.string.release_notes_4_3_0_subtitle_5,
type = ReleaseNoteType.BUGFIX,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_6,
subtitle = R.string.release_notes_4_3_0_subtitle_6,
type = ReleaseNoteType.ENHANCEMENT,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_7,
subtitle = R.string.release_notes_4_3_0_subtitle_7,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_retried_successful_uploads_delete_temporary_folder,
subtitle = R.string.release_notes_4_3_0_subtitle_retried_successful_uploads_delete_temporary_folder,
type = ReleaseNoteType.BUGFIX,
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_improvements_remove_dialog,
subtitle = R.string.release_notes_4_3_0_subtitle_improvements_remove_dialog,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_display_name_truncation,
subtitle = R.string.release_notes_4_3_0_subtitle_display_name_truncation,
type = ReleaseNoteType.BUGFIX
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_improve_available_offline_performance,
subtitle = R.string.release_notes_4_3_0_subtitle_improve_available_offline_performance,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_search_functionality_in_spaces_list,
subtitle = R.string.release_notes_4_3_0_subtitle_search_functionality_in_spaces_list,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_video_streaming_spaces,
subtitle = R.string.release_notes_4_3_0_subtitle_video_streaming_spaces,
type = ReleaseNoteType.BUGFIX
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_accessibility_improvements,
subtitle = R.string.release_notes_4_3_0_subtitle_accessibility_improvements,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_show_app_provider_icon_from_endpoint,
subtitle = R.string.release_notes_4_3_0_subtitle_show_app_provider_icon_from_endpoint,
type = ReleaseNoteType.ENHANCEMENT
),
ReleaseNote(
title = R.string.release_notes_4_3_0_title_av_offline_files_removed_locally_with_local_only_option,
subtitle = R.string.release_notes_4_3_0_subtitle_av_offline_files_removed_locally_with_local_only_option,
title = R.string.release_notes_bugfixes_title,
subtitle = R.string.release_notes_bugfixes_subtitle,
type = ReleaseNoteType.BUGFIX
),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ abstract class DrawerActivity : ToolbarActivity() {
val account = drawerViewModel.getCurrentAccount(this) ?: return
drawerViewModel.getStoredQuota(account.name)
drawerViewModel.userQuota.observe(this) { event ->
getAccountQuotaText()?.setTextColor(getColor(R.color.accessibility_grey_color))
JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
when (val uiResult = event.peekContent()) {
is UIResult.Success -> {
uiResult.data?.let { userQuota ->
Expand Down
2 changes: 2 additions & 0 deletions owncloudApp/src/main/res/layout/share_file_layout.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
android:layout_marginStart="4dp"
android:layout_toEndOf="@+id/shareFileIcon"
android:text="@string/placeholder_filesize"
android:textColor="@color/accessibility_grey_color"
JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
android:textSize="12sp" />

<ImageButton
Expand Down Expand Up @@ -181,6 +182,7 @@
android:paddingRight="@dimen/standard_half_padding"
android:paddingTop="@dimen/standard_padding"
android:text="@string/share_warning_about_forwarding_public_links"
android:textColor="@color/accessibility_grey_color"
android:textSize="15sp" />

<ListView
Expand Down
1 change: 1 addition & 0 deletions owncloudApp/src/main/res/layout/share_public_dialog.xml
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@
android:paddingLeft="@dimen/standard_half_padding"
android:paddingRight="@dimen/standard_half_padding"
android:textSize="12sp"
android:textColor="@color/accessibility_grey_color"
android:visibility="gone" />

<TextView
Expand Down
4 changes: 0 additions & 4 deletions owncloudApp/src/main/res/values-de-rDE/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -665,10 +665,6 @@
<string name="release_notes_footer">Vielen Dank für die Verwendung von %1$s.\n</string>
<string name="release_notes_proceed">Fortfahren</string>
<string name="release_notes_icon">Symbol für Veröffentlichungsnotizen</string>
<string name="release_notes_4_3_0_title_1">Neue Einstellung zum automatischen Entfernen heruntergeladener Dateien, welche eine bestimmte Zeit lang nicht verwendet wurden</string>
<string name="release_notes_4_3_0_subtitle_1">Im Abschnitt „Erweitert“ wurde eine neue Einstellung hinzugefügt, um automatisch heruntergeladene Dateien zu löschen, wenn die Zeit seit ihrer letzten Verwendung die in der Einstellung ausgewählte Zeit überschreitet</string>
<string name="release_notes_4_3_0_title_2">Automatische Konto Erkennung beim Login</string>
<string name="release_notes_4_3_0_subtitle_2">Die Schaltfläche zum Aktualisieren des Kontos wurde in der Ansicht „Konten verwalten“ entfernt, da die automatische Kontoerkennung beim Anmelden erfolgt</string>
<!--Open in web-->
<string name="ic_action_open_in_web">Öffnen im Webbrowser</string>
<string name="ic_action_open_with_web">Öffnen in %1$s (web)</string>
Expand Down
4 changes: 0 additions & 4 deletions owncloudApp/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -664,10 +664,6 @@
<string name="release_notes_footer">Vielen Dank für die Verwendung von %1$s.\n</string>
<string name="release_notes_proceed">Fortfahren</string>
<string name="release_notes_icon">Icon für Veröffentlichungsnotizen</string>
<string name="release_notes_4_3_0_title_1">Neue Einstellung zum automatischen Entfernen heruntergeladener Dateien, welche eine bestimmte Zeit lang nicht verwendet wurden</string>
<string name="release_notes_4_3_0_subtitle_1">Im Abschnitt „Erweitert“ wurde eine neue Einstellung hinzugefügt, um automatisch heruntergeladene Dateien zu löschen, wenn die Zeit seit ihrer letzten Verwendung die in der Einstellung ausgewählte Zeit überschreitet</string>
<string name="release_notes_4_3_0_title_2">Automatische Konto Erkennung beim Login</string>
<string name="release_notes_4_3_0_subtitle_2">Die Schaltfläche zum Aktualisieren des Kontos wurde in der Ansicht „Konten verwalten“ entfernt, da die automatische Kontoerkennung beim Anmelden erfolgt</string>
<!--Open in web-->
<string name="ic_action_open_in_web">Öffnen im Webbrowser</string>
<string name="ic_action_open_with_web">Öffnen in %1$s (web)</string>
Expand Down
42 changes: 0 additions & 42 deletions owncloudApp/src/main/res/values-en-rGB/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -668,50 +668,8 @@
<string name="release_notes_footer">Thank you for using %1$s.\n❤</string>
<string name="release_notes_proceed">Proceed</string>
<string name="release_notes_icon">Release note icon</string>
<string name="release_notes_4_2_2_title_downloads_content_length">Fixes in downloads</string>
<string name="release_notes_4_2_2_subtitle_downloads_content_length">Downloads work properly again for every type of file</string>
<string name="release_notes_4_3_0_title_1">New setting to remove automatically downloaded files that were not used for a certain time</string>
<string name="release_notes_4_3_0_subtitle_1">A new setting has been added in \"Advanced\" section to delete automatically downloaded files, when the time since their last usage exceeds the selected time in the setting</string>
<string name="release_notes_4_3_0_title_2">Automatic discovery of the account in login</string>
<string name="release_notes_4_3_0_subtitle_2">Removed the account refresh button in the Manage Accounts view, as automatic account discovery is done at login</string>
<string name="release_notes_4_3_0_title_4">Name conflicts dialog more Android-alike</string>
<string name="release_notes_4_3_0_subtitle_4">Name conflicts dialogue appearance was changed to look Android-alike and more similar to other dialogues in the app</string>
<string name="release_notes_4_3_0_title_5">Lens icon in folder picker</string>
<string name="release_notes_4_3_0_subtitle_5">The lens icon in the toolbar was removed when listing spaces in folder picker</string>
<string name="release_notes_4_3_0_title_6">Add warning in HTTP connections</string>
<string name="release_notes_4_3_0_subtitle_6">Added a warning dialogue in the login view when it is a HTTP connection</string>
<string name="release_notes_4_3_0_title_7">Correct \"Local only\" option in remove dialogue</string>
<string name="release_notes_4_3_0_subtitle_7">\"Local only\" option in remove dialogue will only be shown if checking selected files and folders recursively, at least one file is available locally</string>
<string name="release_notes_4_3_0_title_retried_successful_uploads_delete_temporary_folder">Retried successful uploads are cleaned up from the temporary folder</string>
<string name="release_notes_4_3_0_subtitle_retried_successful_uploads_delete_temporary_folder">Temporary files related to an upload are deleted after the retried successful uploads is finished</string>
<string name="release_notes_4_3_0_title_manual_removal_local_storage">New setting to removal manually local storage</string>
<string name="release_notes_4_3_0_subtitle_manual_removal_local_storage">A new icon has been added in Manage Accounts view to delete manually local and temporary files</string>
<string name="release_notes_4_3_0_title_clear_data_button_hard_reset">\"Clear data\" button enabled in the app settings in device settings</string>
<string name="release_notes_4_3_0_subtitle_clear_data_button_hard_reset">The \"Clear data\" button has been enabled to delete the application data from the app settings in the device settings. The application will perform a hard reset if this button is pressed</string>
<string name="release_notes_4_3_0_title_improvements_remove_dialog">Improvements in remove dialogue</string>
<string name="release_notes_4_3_0_subtitle_improvements_remove_dialog">A new remove dialogue has been created by adding the thumbnail of the file to be deleted. Added the number of files that are going to be deleted in a multiple selection</string>
<string name="release_notes_4_3_0_title_password_generator">Password generator for public links</string>
<string name="release_notes_4_3_0_subtitle_password_generator">Passwords for public links can be now generated via a new generator in Infinite Scale accounts</string>
<string name="release_notes_4_3_0_title_display_name_truncation">Resolved the bug where long display names were truncated incorrectly</string>
<string name="release_notes_4_3_0_subtitle_display_name_truncation">Display names are now properly truncated in the middle with ellipsis (…) to maintain readability</string>
<string name="release_notes_4_3_0_title_improve_available_offline_performance">Improvements in available offline performance</string>
<string name="release_notes_4_3_0_subtitle_improve_available_offline_performance">Files contained in an available offline folder will be refreshed only if they have been modified</string>
<string name="release_notes_4_3_0_title_search_functionality_in_spaces_list">Search functionality in spaces list</string>
<string name="release_notes_4_3_0_subtitle_search_functionality_in_spaces_list">Search functionality has been added in spaces list when you are trying to filter them</string>
<string name="release_notes_4_3_0_title_video_streaming_spaces">Video streaming in spaces</string>
<string name="release_notes_4_3_0_subtitle_video_streaming_spaces">Video files located in spaces can now be played in streaming correctly</string>
<string name="release_notes_4_3_0_title_accessibility_improvements">Improvements in accessibility</string>
<string name="release_notes_4_3_0_subtitle_accessibility_improvements">Some improvements to make the application more accessible</string>
<string name="release_notes_4_3_0_title_show_app_provider_icon_from_endpoint">New icons in \"Open in (web)\" option on the operations menu</string>
<string name="release_notes_4_3_0_subtitle_show_app_provider_icon_from_endpoint">More appropriate icons have been added to the \"Open in (web)\" option on the operations menu</string>
<string name="release_notes_4_3_0_title_av_offline_files_removed_locally_with_local_only_option">Displayed \"Local only\" option properly and prevented deletion of available offline files in the remove dialogue</string>
<string name="release_notes_4_3_0_subtitle_av_offline_files_removed_locally_with_local_only_option">\"Local only\" option in the remove dialogue will be shown when the selected folder contains at least one downloaded file, ignoring those available offline. If the \"Local only\" option is displayed and clicked, available offline files will not be deleted</string>
<string name="release_notes_4_3_0_title_create_open_shortcut">Support for URL shortcut files</string>
<string name="release_notes_4_3_0_subtitle_create_open_shortcut">A new option has been added in the floating button to create a shortcut file with a .url extension. When the file is clicked, the URL will open in the browser</string>
<string name="release_notes_4_3_0_title_report_feedback_central_github">Changes in the Feedback section</string>
<string name="release_notes_4_3_0_subtitle_report_feedback_central_github">A new dialogue has been added to handle feedback: the ownCloud survey, GitHub and the open forum Central will be our meeting point</string>
<string name="release_notes_4_3_0_title_new_ui_manage_accounts">New dialogue for \"Manage accounts\"</string>
<string name="release_notes_4_3_0_subtitle_new_ui_manage_accounts">All the accounts management stuff has been moved to a new dialogue that appears when pressing the avatar. The drawer menu has been simplified removing all accounts management-related stuff as well</string>
<!--Open in web-->
<string name="ic_action_open_in_web">Open in web</string>
<string name="ic_action_open_with_web">Open in %1$s (web)</string>
Expand Down
Loading
Loading