-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] 11.2.4.7 Focus visible #4446
base: master
Are you sure you want to change the base?
Conversation
This issue is blocked until a migration to Material 3 is done. This new approach has been proposed because there is a conflict between the colors when they are focused/unfocused. In addition, there is also a conflict between the focus color and the texts/icons that are inside the elements. If we have a Material 3 palette, all these conflicts should be solved. Below are the things that have been taken into account in this issue, ignoring the further development of Material. Points to keep in mind: List of files. The current focus of the default application ( Toolbar: This element presents a similar problem. If we put a white At this point another doubt arises that is more visible in the create Another thing to keep in mind is that in this issue the color of the press element will not be taken into account. The only thing to know here is that the press element sets the elements to a darker shade. On the other hand, we must also take into account the brandable colors. As the application is now, two brandable colors should be created for the focus. One for the toolbar and bottom navigation elements. And another for the buttons with the primary style (check style.xml) and the floating button. This pull request has taken into account these considerations mentioned above. In addition, for buttons with borderless, a new style has been created that can fit with the focus ( As a last piece of information to add, this branch has been taken from the keyboard navigator branch. The work here is far from finished, but it is a good starting point to continue what has been started if Material is not finally implemented before this issue. For the collection of colors the following page has been used: https://pickcoloronline.com/ |
Related Issues
App: #4369
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA